Skip to content

SD lib - AcquireSPI on ff_sd_status #8536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 29, 2023
Merged

SD lib - AcquireSPI on ff_sd_status #8536

merged 1 commit into from
Aug 29, 2023

Conversation

P-R-O-C-H-Y
Copy link
Member

Description of Change

Added missing AcquireSPI lock in ff_sd_status function in SD library. Fixing conflict when sharing the same SPI bus in multi tasks. Thanks @LeoYan for providing the fix in issue #8534

Should be merged to both 2.x release branch and 5.1-libs branch.

Tests scenarios

Related links

Closing #8534

@P-R-O-C-H-Y P-R-O-C-H-Y added the Area: Libraries Issue is related to Library support. label Aug 16, 2023
@P-R-O-C-H-Y P-R-O-C-H-Y self-assigned this Aug 16, 2023
@P-R-O-C-H-Y P-R-O-C-H-Y changed the title AcquireSPI on ff_sd_status SD lib - AcquireSPI on ff_sd_status Aug 16, 2023
@P-R-O-C-H-Y P-R-O-C-H-Y modified the milestones: 2.0.12, 3.0.0 Aug 16, 2023
@VojtechBartoska VojtechBartoska requested review from SuGlider, me-no-dev and lucasssvaz and removed request for SuGlider August 23, 2023 11:51
@VojtechBartoska VojtechBartoska added the Status: Review needed Issue or PR is awaiting review label Aug 23, 2023
lucasssvaz
lucasssvaz approved these changes Aug 24, 2023
View reviewed changes
Copy link
Member

@lucasssvaz lucasssvaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@me-no-dev me-no-dev merged commit fc438b1 into espressif:master Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasssvaz lucasssvaz lucasssvaz approved these changes

@me-no-dev me-no-dev Awaiting requested review from me-no-dev

Assignees

@P-R-O-C-H-Y P-R-O-C-H-Y

Labels
Area: Libraries Issue is related to Library support. Status: Review needed Issue or PR is awaiting review
Projects
Arduino ESP32 Core Project Roadmap
Status: Done
Milestone
2.0.12
Development

Successfully merging this pull request may close these issues.
4 participants
@P-R-O-C-H-Y @lucasssvaz @me-no-dev @VojtechBartoska